Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user-set partial charge warning #330

Open
JenkeScheen opened this issue Jun 25, 2024 · 3 comments
Open

user-set partial charge warning #330

JenkeScheen opened this issue Jun 25, 2024 · 3 comments

Comments

@JenkeScheen
Copy link

With the current setup in openfe every time a molecule gets loaded with user-set partial charges the user receives a warning Partial charges have been provided, these will preferentially be used instead of generating new partial charges. This becomes a bit much when we're loading hundreds of molecules in production, especially when we load/de-load the set of molecules multiple times during prep and setup steps ahead of simulations.

Is there a way to log this more elegantly, or potentially expose a flag for users to disable this warning?

We've now gotten around this by just ignoring this warning but an openfe-side solution would be preferable: https://github.com/asapdiscovery/asapdiscovery/blob/main/asapdiscovery-alchemy/asapdiscovery/alchemy/cli/cli.py

@IAlibay
Copy link
Member

IAlibay commented Jun 25, 2024

Thanks @JenkeScheen , we'll give it a think - possibly shifting to logging rather than warnings. I'm going to triage this as "low prioirity", but please do let me know if you feel it isn't.

@IAlibay IAlibay transferred this issue from OpenFreeEnergy/openfe Jul 2, 2024
@IAlibay
Copy link
Member

IAlibay commented Sep 25, 2024

Just coming back to this, we are definitely not removing the warning, the best we can do is change to a logging.warning instead of a userwarning.

@JenkeScheen
Copy link
Author

sure - as long as it's mutable then that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants