Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify_dependencies does not recursively deserialize gufetokenizables #343

Open
IAlibay opened this issue Sep 7, 2024 · 2 comments
Open

Comments

@IAlibay
Copy link
Member

IAlibay commented Sep 7, 2024

The use case

I have a subclass of a SolventComponent that has a SmallMoleculeComponent as one of its attributes.

The problem

Roundtripping on keyed dict fails because (in part) modify_dependencies does not deserialize the SmallMoleculeComponent in the dict.

@dotsdl
Copy link
Member

dotsdl commented Sep 11, 2024

@IAlibay can you point us to where this class is implemented? Or provide it here as a snippet and show what it is you are trying that produces the failure?

@IAlibay
Copy link
Member Author

IAlibay commented Sep 11, 2024

@dotsdl of course, here is the code, including my current short time fix (had to reimplement the shallow/keyed dict method) https://github.com/IAlibay/pontibus/blob/develop/src%2Fpontibus%2Fcomponents%2Fextended_solvent_component.py

@dotsdl dotsdl added this to the Release 1.3 milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants