Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More LED Animations #94

Open
NeonDaniel opened this issue Nov 18, 2022 · 3 comments
Open

More LED Animations #94

NeonDaniel opened this issue Nov 18, 2022 · 3 comments
Assignees

Comments

@NeonDaniel
Copy link
Member

NeonDaniel commented Nov 18, 2022

As noted in #88, there are several events that should trigger some LED activity. We should pick some default animations to implement for different events:

  • Internet disconnected/reconnected (one-shot)
  • Device Offline (persistent)
  • Low priority notification (persistent?)
  • High priority notification (persistent)
  • Starting Up (persistent)
  • Shutting Down (persistent? Will be terminated at some point as the plugin is shutdown)

Current Animations:
chase
breathe
fill
refill (fill color, fill black, repeat)
bounce (fill color, reverse fill black, repeat)
blink

Potential Animations:
Comet (Dinkum example), like chase but with fade effects
Alternating (alternate even/odd leds)
...

@JarbasAl
Copy link
Member

i think we should have 2 blinks, a constant blink and a blink 3 and sleep in between, blink3 is what already exists with minor tweaks

we also want to abstract "speak" animation and expose it to individual plugins, this could be a blink with random sleeps or something

if led support sbrightness, would be nice to have a "decay" animations, all leds going 0 -> 100 -> 0 brightness on a loop. this would be nice for boot/shutdown events

@NeonDaniel
Copy link
Member Author

i think we should have 2 blinks, a constant blink and a blink 3 and sleep in between, blink3 is what already exists with minor tweaks

The blink animation is configurable for number of blinks https://github.com/OpenVoiceOS/ovos-plugin-manager/blob/dev/ovos_plugin_manager/hardware/led/animations.py#L194

Constant blinking would be a good one too; we could handle -1 or 0 as a special case in the existing blink animation or spec a separate one..

we also want to abstract "speak" animation and expose it to individual plugins, this could be a blink with random sleeps or something

I could take the same approach as utterance and let some animation be specified to run on speak? Or would it be better to tie it to audio_output_start/end?

if led support sbrightness, would be nice to have a "decay" animations, all leds going 0 -> 100 -> 0 brightness on a loop. this would be nice for boot/shutdown events

This is the 'breathe' animation https://github.com/OpenVoiceOS/ovos-plugin-manager/blob/dev/ovos_plugin_manager/hardware/led/animations.py#L27 . Currently the default for listening (matches Mycroft Core and Dinkum behavior), so I'd like to pick something else for startup/shutdown

@5trongthany
Copy link
Member

Would we be able to incorporate something like a yawn into a startup animation? I feel like that would be a decent way to signify starting up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants