Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about image resolution #64

Open
KN-Zhang opened this issue Jun 12, 2024 · 1 comment
Open

about image resolution #64

KN-Zhang opened this issue Jun 12, 2024 · 1 comment

Comments

@KN-Zhang
Copy link

Hi! In Table 8 of the original paper, do you keep the test image resolution the same as the training image resolution? For example, when training on 384x512 image pairs, do you also resize all the test image pairs to 384x512 for testing? Actually I am following roma. But I found this dense pipeline is a bit sensitive to the resolution setting. So I want to find a way to make the method generalize well to different resolutions. :)

@Parskatt
Copy link
Owner

Thats great, generalizing resolution is definitely something I would want.

As to your question, we set the resolution for the global/coarse matching to be a bit over the train resolution (perhaps 660x880 or so, cmp 540×720). It is indeed sensitive to this.

We then run the refinement (upsample re) at much higher resolution (typically maybe 1000px).

In general Ive found that the refiners are very robust to different resolutions (there are some caveats, look in the roma code for something like scale_factor).

If I were to do fix the resolution problem I would probably look at replacing the GP, as it scales poorly with high res. Perhaps flash attention instead? Let me know how it goes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants