Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy "examples" #77

Open
4 tasks
PaulieScanlon opened this issue Sep 9, 2020 · 2 comments
Open
4 tasks

Deploy "examples" #77

PaulieScanlon opened this issue Sep 9, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@PaulieScanlon
Copy link
Owner

After speaking with @molebox it's probably a good idea to get each of the examples deployed somewhere and from here in Storybook docs we can advise users on how to install MDX Embed for each of the examples, point them to both a dir in the repo and an online site

The current examples are:

  • gatsby-demo
  • mdx-deck-demo
  • next-mdx-deck-demo
  • next-mdx-demo

Once i've worked out how best to deploy this without messing up the build pipeline i'll back back in on this issue with links to where they can be seen

@PaulieScanlon PaulieScanlon added the enhancement New feature or request label Sep 9, 2020
@PaulieScanlon PaulieScanlon self-assigned this Sep 9, 2020
@PaulieScanlon
Copy link
Owner Author

PaulieScanlon commented Sep 9, 2020

I gave this a go and created a new site from Git in Netlify and pointed the build command at the build command in root package.json for the gatsby-demo and set the publish dir to examples/gatsby-demo

but...

The build keeps failing complaining it can't find the mdx-embed package... i don't know why this? the * should just mean it installs from npm right? or does it need a version number if it can't resolve the node_modules locally?

Either way i've killed my build minutes for this months so will have to circle back to this.

@PaulieScanlon PaulieScanlon added the help wanted Extra attention is needed label Sep 9, 2020
@PaulieScanlon
Copy link
Owner Author

Ok i know what this is now...

When i was deploying to Netlify i wasn't building the package. All the demo use "mdx-embed" "*" which will resolve to mdx-embed/dist but when deploying the dist dir isn't there 🤦 so a yarn build needs to be part of the Netlify .toml so the package is built... i'll give this another stab later to check that is what the problem is

@PaulieScanlon PaulieScanlon removed the help wanted Extra attention is needed label Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant