Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat resume-ability #189

Open
krishokr opened this issue Aug 9, 2024 · 2 comments
Open

Chat resume-ability #189

krishokr opened this issue Aug 9, 2024 · 2 comments

Comments

@krishokr
Copy link
Collaborator

krishokr commented Aug 9, 2024

Issue

The UI is not resuming the conversation when the stream is aborted.

@krishokr krishokr changed the title On stream abort, delete last human message On stream abort, remove last human message Aug 9, 2024
@krishokr krishokr changed the title On stream abort, remove last human message stack: On stream abort, remove last human message Aug 9, 2024
@krishokr krishokr changed the title stack: On stream abort, remove last human message On stream abort, remove last human message Aug 9, 2024
@krishokr krishokr changed the title On stream abort, remove last human message On stream abort, remove last human message and tool call Aug 9, 2024
@danorlando
Copy link
Collaborator

We dont want to be removing messages... The advantage of this design is that conversations are resumable. When you abort, the chat is "paused" with the incomplete ai message removed so you can then edit the human message and save and continue or simply click continue, at which point the last query is resubmitted. I strongly recommend playing with this functionality in opengpts project to see how it is supposed to work. (use docker compose as their deployed version was severely out of date last time i looked)

So I think the functionality is correct but there is a bug that I need to look at.

@krishokr
Copy link
Collaborator Author

Sounds like the human message shouldn't be saved then.

@danorlando danorlando changed the title On stream abort, remove last human message and tool call Chat resume-ability Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants