From 1a4d1db0bfedfec6b7320a125da68713998c71aa Mon Sep 17 00:00:00 2001 From: Johan Dahlberg Date: Mon, 23 Oct 2023 09:32:58 +0000 Subject: [PATCH 1/3] Add comment explaining agg test --- tests/test_pixeldataset.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/test_pixeldataset.py b/tests/test_pixeldataset.py index 18894c3a..4f0d9146 100644 --- a/tests/test_pixeldataset.py +++ b/tests/test_pixeldataset.py @@ -758,6 +758,10 @@ def test_aggregation_all_samples_show_up( tmp_path, setup_basic_pixel_dataset, ): + # There used to be a bug (EXE-1186) where only the first to samples + # were actually aggregated. This test is here to catch that potential + # problem in the future. + dataset_1, *_ = setup_basic_pixel_dataset dataset_2 = dataset_1.copy() dataset_3 = dataset_1.copy() From 7a83680dce9f438c6efc6a507ca3aa613c2e7ce7 Mon Sep 17 00:00:00 2001 From: Johan Dahlberg Date: Mon, 23 Oct 2023 09:35:20 +0000 Subject: [PATCH 2/3] Prep 0.15.2 release notes --- CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2123837c..3fe19401 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,13 +5,13 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). -## [UNRELEASED] - ... +## [0.15.2] - 2023-10-23 ### Fixed * Fixed broken pixeldataset aggregation for more than two samples. * Fixed a bug in graph generation caused by accidentally writing the index to the parquet file. - For backwards compatiblity, if there is an column named `index`` in the edgelist, this + For backwards compatiblity, if there is an column named `index` in the edgelist, this will be removed and the user will get a warning indicating that this has happened. ## [0.15.1] - 2023-10-18 From a205c2fa2fd395232b611c9a483f1e5690569557 Mon Sep 17 00:00:00 2001 From: Johan Dahlberg Date: Mon, 23 Oct 2023 09:36:25 +0000 Subject: [PATCH 3/3] Fix typo --- tests/test_pixeldataset.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_pixeldataset.py b/tests/test_pixeldataset.py index 4f0d9146..a5c96d93 100644 --- a/tests/test_pixeldataset.py +++ b/tests/test_pixeldataset.py @@ -758,7 +758,7 @@ def test_aggregation_all_samples_show_up( tmp_path, setup_basic_pixel_dataset, ): - # There used to be a bug (EXE-1186) where only the first to samples + # There used to be a bug (EXE-1186) where only the first two samples # were actually aggregated. This test is here to catch that potential # problem in the future.