Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterLab WIPP Plugin Creator sidebar logo blown out on Edge on Mac #25

Open
ktaletsk opened this issue Oct 10, 2021 · 0 comments
Open
Labels
bug Something isn't working

Comments

@ktaletsk
Copy link
Collaborator

Summary

On other browsers the size is adjusted properly.

What is the current bug behavior?

Logo is way to large and extends across the whole page, blocking other buttons under it

What is the expected correct behavior?

Icon is the same size as other icons in the sidebar

Steps to reproduce

(How one can reproduce the issue - this is very important)

Relevant screenshots and/or logs

image

Environment info

Microsoft Edge
Version 96.0.1040.0 (Official build) Canary (arm64)

Possible fixes

We need to change the height and width in the svg to a smaller number
https://github.com/LabShare/jupyterlab-extensions/blob/96c8426fdf1b99417068f9bc4ef8c72524d5f6ce/jupyterlab_wipp_plugin_creator/style/logo.svg#L1

something like 400, like in JupyterLab WIPP
https://github.com/LabShare/jupyterlab-extensions/blob/96c8426fdf1b99417068f9bc4ef8c72524d5f6ce/jupyterlab_wipp/style/logo-wipp.svg#L1

@ktaletsk ktaletsk added the bug Something isn't working label Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant