Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterLab WIPP Plugin Creator install_requires should contain kubernetes #32

Open
ktaletsk opened this issue Oct 23, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@ktaletsk
Copy link
Collaborator

Summary

Extension requires kubernetes to be pip-installed, but lacks the dependency listing in install_requires inside setup.py.

What is the current bug behavior?

pip install fails if kubernetes is not installed

What is the expected correct behavior?

pip installs kubernetes automatically, because it is a dependency

Steps to reproduce

pip install on a clean environment (that does not have kubernetes installed

**Notes

We should remove a workaround from Github action as well

@ktaletsk ktaletsk added the bug Something isn't working label Oct 23, 2021
akisaini pushed a commit to akisaini/jupyterlab-extensions that referenced this issue Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant