Skip to content

Install script blindly sets client_min_messages, overriding the caller's setting #89

Description

@jnasbyupgrade

The cat_tools install script sets SET LOCAL client_min_messages = WARNING near the top of the extension SQL.

Because SET LOCAL is transaction-scoped and CREATE EXTENSION runs in a single transaction, this overrides whatever the caller had set — for the entire CREATE EXTENSION (including any CASCADE that pulls cat_tools in as a dependency).

Impact: a caller who deliberately sets a stricter level (e.g. SET client_min_messages = error to keep install output quiet) is silently overridden, so cat_tools's own messages — notably the function__arg_types_text() is deprecated warning — still print and cannot be suppressed by the caller.

Suggestion: inspect the current value before changing it rather than blindly forcing WARNING — e.g. only lower verbosity when the caller hasn't already set a stricter level, or save the prior value and restore it at the end. That keeps cat_tools' own install output tidy without stomping a caller's intentional setting.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions