Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata editing at the nominate level #940

Open
AramZS opened this issue Sep 25, 2017 · 11 comments
Open

Metadata editing at the nominate level #940

AramZS opened this issue Sep 25, 2017 · 11 comments

Comments

@AramZS
Copy link
Member

AramZS commented Sep 25, 2017

No description provided.

@jccatalano
Copy link

jccatalano commented Jan 22, 2018

The editing icon appears, I modified each field; but, the "Save" button does not function for the metadata editing field. Once clicked the window remains open.

@jccatalano
Copy link

jccatalano commented Jan 22, 2018

It appears that this may be impacted by method of nomination. I can edit nominations that came via the bookmarklet but not all content.

@jccatalano
Copy link

For the posts nominated via the bookmarklet, I am able to modify the tags and author and these changes are reflected in the post meta data. However, changes made to Source Title and Origin Item URL are not reflected in the post meta data.

@jccatalano
Copy link

Should users be able to modify the Submitted By field? Since this is based off of user numbers instead of names, I am not sure that this will be a meaningful functionality. Because this is based upon the user number, it is possible that people may confuse this with the number of nominations (not the number(s) of the nominators). If a user can delete or add the numbers of nominators, what impact will that have on the valid of the post metadata for nominations?

@lcrossley
Copy link

For posts nominated via bookmarklet, when I delete all of the original tags in Nominated and add a new tag, then send the item to draft, the new tag gets added in the draft, but the original tags are still there, too. When I check the metadata in Nominated or try to edit it again, then only the new tag is there.

@AramZS
Copy link
Member Author

AramZS commented Jan 23, 2018

@jccatalano the changes aren't reflected in the post meta data even after refresh for those two fields?

@jccatalano
Copy link

Correct. The changes do not appear anywhere even if the nomination is published.

AramZS added a commit that referenced this issue Feb 3, 2018
@AramZS AramZS added Test and removed bug labels Feb 3, 2018
@jccatalano
Copy link

Should Thumbnail ID, Date Posted on Source, Nomination Datetime, & Date added to PressForward be options for editing?

@jccatalano
Copy link

There is also a discrepancy between what fields can be edited based upon the nomination method. If editing a post that originated from all content only Date Posted on Source, Author(s), Date added to PressForward, Nomination Datetime, & Thumbnail ID are options to edit.

Meanwhile, posts via the bookmarklet have Date Posted on Source, Author(s), Date added to PressForward, Nomination Datetime, Thumbnail ID, Origin Item URL, Source Title, & Tags.

@jccatalano
Copy link

The save button does not work for posts that originate from all content.

@AramZS
Copy link
Member Author

AramZS commented Feb 13, 2018

Moving this to 5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants