Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApprovalForAll for delegate #657

Open
cody-evaluate opened this issue Oct 12, 2024 · 0 comments
Open

ApprovalForAll for delegate #657

cody-evaluate opened this issue Oct 12, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@cody-evaluate
Copy link

cody-evaluate commented Oct 12, 2024

Component

Other (please describe)

Describe the feature you would like

Address 1 is the offerer
Address 2 owns NFT 1
Address 3 owns NFT 2
Address 4 owns NFT 3

Address 2 setApprovalForAll Address 1 as an operator for NFT 1
Address 3 setApprovalForAll Address 1 as an operator for NFT 2
Address 4 setApprovalForAll Address 1 as an operator for NFT 3

Address 1 should now be able to create an offer containing NFT 1, NFT 2 and NFT 3 and send to Address 5

Address 5 can now fulfill the offer even though Address 1 owns none of the offered NFTs but was approved as an operator by the respective owners.

Solution

expose an optional owner prop on every item in the offer and consideration array which will essentially act as conduits per item and approvals will be checked accordingly.

No response

@cody-evaluate cody-evaluate added the enhancement New feature or request label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant