Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Much more deep tests #105

Open
3 of 4 tasks
yhamoudi opened this issue Feb 5, 2015 · 5 comments
Open
3 of 4 tasks

Much more deep tests #105

yhamoudi opened this issue Feb 5, 2015 · 5 comments

Comments

@yhamoudi
Copy link
Member

yhamoudi commented Feb 5, 2015

We should add as much as possible deep tests in data_deep.py. Every time we discover a question well parsed by our algorithm, we should add it immediately into this file. Thus, when we'll make some changes on the algorithm, it will not be necessary to check many examples manually to be sure that we didn't broke a useful rule.

(naturally, it's not necessay to add questions with the same structure, ex: Who is the president of France? and Who is the president of Germany?)

Let's close this issue when there will be 200 tests :)

  • 50 tests done
  • 100 tests done
  • 150 tests done
  • 200 tests done
@yhamoudi
Copy link
Member Author

yhamoudi commented Feb 5, 2015

I've shortened the way we write deep tests. We can at least write each triple on a single line.

@Ezibenroc
Copy link
Member

👍

But 200 tests with different structures seems a bit ambitious.

@yhamoudi
Copy link
Member Author

yhamoudi commented Feb 5, 2015

there are already a lot of tests in documentation/

@yhamoudi
Copy link
Member Author

yhamoudi commented Feb 7, 2015

But 200 tests with different structures seems a bit ambitious.

We can mix some difficulties. For instance Who is the president of Germany? and Who is the president of the United States? have the same grammatical structure but in the second case there is a merging (United + States)

I've added some achievements in the first post 💰 (and i've discovered the supported emoji)

@Ezibenroc
Copy link
Member

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants