Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean the repository #127

Open
5 of 6 tasks
Ezibenroc opened this issue Feb 18, 2015 · 1 comment
Open
5 of 6 tasks

Clean the repository #127

Ezibenroc opened this issue Feb 18, 2015 · 1 comment

Comments

@Ezibenroc
Copy link
Member

Once we merge reverse_predicates into master we should clean the repository.
Do not do it before, this branch is already huge (please do less modifications per pull request, it is really painfull to review/understand).
Do not begin new stuff, we really need to clean what already exists.

Non exhaustive list:

  • Better documentation.
    • No more French (by the way, there is also French in the comments of the code).
    • Better structure (a Wiki?)
  • Better code.

Feel free to complete this list.


TODO:

  • Spaces after commas.
  • nounDB.py
  • preprocessing.py
  • initialMerge.py
  • dependencyTree.py
  • Remainder.
@yhamoudi
Copy link
Member

No more French (by the way, there is also French in the comments of the code).

My bad for the comments in french, they have been translated. Concerning the other parts in french, they should be only in documentation/ and they are not supposed to be read by "external" people (i can remove them from the repository, but it's more convenient to put them here...)

Avoir long and complicated functions like processQuestionInfo.

I tried to shortened it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants