Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Property to ChangeEvent #4

Open
CodeRhymesLife opened this issue Mar 7, 2017 · 1 comment
Open

Pass Property to ChangeEvent #4

CodeRhymesLife opened this issue Mar 7, 2017 · 1 comment
Assignees

Comments

@CodeRhymesLife
Copy link
Contributor

Will make event handling much cleaner

@CodeRhymesLife CodeRhymesLife self-assigned this Mar 7, 2017
@CodeRhymesLife
Copy link
Contributor Author

I still want to do this, but, with the way things are now, this change would turn Property into Property<T, PT>, where T is the value type and PT is the property type (e.g. GameObjectProperty). The reason we need PT would be to have the right type passed to the onchange handler in the Property base class. I like Property the way it is because it can be used by other, non-GameObject related objects. It's a nice thing to have.

But it would also be much easier to handle events if the property was passed to them. Keeping this open for the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant