Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUI element gets assinged the wrong text #524

Open
NoCatt opened this issue Oct 23, 2022 · 4 comments
Open

RUI element gets assinged the wrong text #524

NoCatt opened this issue Oct 23, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@NoCatt
Copy link
Contributor

NoCatt commented Oct 23, 2022

When I try to execute an announcement with NSSendAnnouncementMessageToPlayer at the same time as I execute NSEditStatusMessageOnPlayer on the same player (same function or function called at the same time) the text from the status message appears in the announcement.
This is what the person who killed the player sees (with the wrong text):
RUI bug screenshot 1
and this is what the killed person sees (the right text):
RUI bug screenshot 2

@ASpoonPlaysGames
Copy link
Contributor

Should this be closed now?

@Erlite
Copy link
Contributor

Erlite commented Dec 15, 2022

Still happens, so no. Gave a quick look and it might be due to successive RUI calls overriding the parameters through server to client string commands?

Overall, I'd suggest completely getting rid of threading, doesn't seem to be required. Processing a queue of pending RUIs and an array of ongoing RUIs every frame should work fine and keep the code a lot more maintainable in the long run.

For sending data, I would suggest packing everything in a single server to client command instead of multiple for each data type. You could probably encode data based on RUI type and read it back (with some sanity checks) on the client. And then directly queue it instead of waiting for the final ServerHUDMessageShow command.

@EnderBoy9217
Copy link
Contributor

Still happens, has been plaguing me for a while.
Typically happens when two RUI elements are sent at similar times, I have more obvious video evidence if needed.

@EnderBoy9217
Copy link
Contributor

Also would like to say this is not exclusive to NSEditStatusMessageOnPlayer, it has happened frequently with popup text being replaced with info text, info text being replaced with new status message text, etc.

@ASpoonPlaysGames ASpoonPlaysGames added the bug Something isn't working label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

4 participants