Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the Cryptocurrency Name #6

Open
screwgoth opened this issue Jan 11, 2018 · 6 comments
Open

Show the Cryptocurrency Name #6

screwgoth opened this issue Jan 11, 2018 · 6 comments

Comments

@screwgoth
Copy link

Currently the table shows only the Symbol. It should also show name of the cryptocurrency.
Additionally it should be possible to find using the name and not just the symbol.

@RDCH106
Copy link
Owner

RDCH106 commented Jan 11, 2018

@screwgoth First of all thank you for your contribution!!

I will check it and I will decide if it is good option to add one more column. The table could be very width...

@vgonisanz
Copy link
Collaborator

In my opinion, more colums will be too far... Anyway, It will be possible to add some options to show/hide columns. What do you think?

@screwgoth
Copy link
Author

Doesn't look too wide in my opinion (see screenshot).
pycoinmon terminal screenshot

But if you still feel so, what did you mean by "options to show/hide columns" exactly ?

@RDCH106
Copy link
Owner

RDCH106 commented Jan 12, 2018

It will more interesting create different a type of template with different columns configuration.

The idea is add a param called -t o --template and specify the template. For example:

pycoinmon --template coinmon

Where coinmon will be the current template (the same that use coinmon project)

I agree with @vgonisanz, it is too wide.

@RDCH106
Copy link
Owner

RDCH106 commented Jan 12, 2018

For example, I use a tablet with Windows 10. If I print the code with the name column, the table use all the width of the console:

imagen

Also I can see an error because the price column is green and has percentage... Same problem for change(1h) column.

@screwgoth
Copy link
Author

Fixed the error about the price color and % symbol showing up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants