-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differentiate remediation types in has_no_remediation()
#87
Comments
For searching Ansible remediation, we could utilize similarly as for Bash However, this approach will not work for IB as |
Significant help towards this is e1100f0 done via #155 . This allows us to directly query bash/ansible/etc. remediations in the datastream XML. Now we'd need to figure out how |
The main reason we need to do this is to fix some false positives on non-Bash remediation technologies. For example - kickstart / OAA / image-builder hardening should remediate some things that oscap alone cannot, like disk partitions (ie. by including them in an osbuild blueprint), and scans for those hardening types should not auto-waive failures in those rules. Doing so can lead to hiding bugs. |
Currently, the function looks for Bash remediations only - this may incorrectly waive failing Ansible results that do have a valid Ansible remediation, but no Bash remediation scripts.
Also, the existing Bash-based logic is fairly hacky and manual. Try parsing the datastream XML instead.
The text was updated successfully, but these errors were encountered: