Rock Band 2 guitar selector switch and overdrive

[AARP41298]

Quick summary

Doesnt matter wich device class select, it doesnt fits at all

Details

Hi, i just found the amazing RB2 Deluxe and start to play with an 360 RB1 guitar
The thing is, to activate the overdrive/star power with guitar in vertical position, i have to remap RS Y+ to R1
And the selector switch is in the LT but it has to remap to Right Stick Up and Down for the correct functionality.
my question is
Does rpcs3 support LT+ and LT-?
in other words
i think i can solve this changing the maping "rules"
insted of 0-100 LT to 0-100 RS Up

something like 50-100 LT+ to 0-100 RS Up
and 50-0 LT- to 0-100 RS Down

Attach a log file

No response

Attach capture files for visual issues

No response

System configuration

No response

Other details

No response

[MSuih]

Could you clarify a bit about what you exactly want us to change? We had three people trying to decipher your message but couldn't quite figure it out.

[YuriNator557]

Basically the Rock Band guitars have this little slider thing that can be used ingame to change how the guitar tone sounds I believe

There isn't really a way of getting this working in RPCS3 since it seems to do something weird on the right stick to make it work?

To activate Overdrive (same thing as Guitar Hero's Star Power) normally the guitar would need to be tilted up or press the Select button, but currently in RPCS3 it will just activate automatically as soon as you get enough Overdrive, I think they are asking if it is possible to fix this?

[Darkhost1999]

I see this as duplicate feature request.

Please add the ability to map more than 1 physical button to 1 emulated button.
Because I need to map Right stick up and down both to Left Trigger to get my Xbox 360 guitar to work correctly.

They're also saying something about Left trgger + and left trigger - that I would assume is actually supposed to be left and right trigger.

[AARP41298]

Sorry @MSuih, i hope this time i could give you a better explain of what is exactly is happening

This is the normal behavior as i remember in 360
NOTE: Ignore the right stick, that becase the whammy and it works great

This is the behavior using an 360 controller as a Device Class-Guitar-Rock Band

And this is the behavior using the guitar controller as a Device Class-Guitar-Rock Band changing the LT to RS Down

As you can see, there is an offset in the effects
I think that the cuoted feature of @Darkhost1999 is the same problem
Thats why im asking for a LT+ and LT- support
or maybe an "Half LT+" and "Half LT-" support? IDK

PD I found a problem with Solo Buttons, do i need to rename this issue an explain it here, or i need to open a new issue?

Thank you so much for the replies

[AARP41298]

Hey @Darkhost1999 wich number is that issue?

[AARP41298]

Maybe using xoutput...

[Megamouse]

I don't understand the problem to be honest.
You can't map a trigger to the whole axis.
But why do you want that in the first place?
Why can't you just use the stick normally?
Why can't you just use the other trigger for the lower half of the stick axis?
Why does RSY+ have to be mapped to R1?

[sanjay900]

I don't understand the problem to be honest. You can't map a trigger to the whole axis. But why do you want that in the first place? Why can't you just use the stick normally? Why can't you just use the other trigger for the lower half of the stick axis? Why does RSY+ have to be mapped to R1?

The different consoles handle the pickup selector differently. On the 360, the selector is mapped to the Left Trigger, while on the ps3, its mapped to the full range of the right stick y axis. I guess the problem here is that no way to map the trigger across the axis, making it impossible to map the pickup selector from a xbox 360 guitar to RPCS3.

If it helps, i was helping with some documentation on all these guitars, as I have been working on emulating them on a pi pico with console support, so there are some really nice notes here now: https://github.com/TheNathannator/PlasticBand/tree/main/Docs/Instruments/5-Fret%20Guitar/Rock%20Band

The PS3 guitars throw an extra curve ball in that the value from them is set back to 0x7f a second or so after you put them in position, which is not something the 360 guitars do, but I'm not sure if the game will care about that.

[sanjay900]

Guitar inputs are weird right, I even recently discovered that even whammy differs on all the guitars even on the same platform. For example, xb360 guitars use the full right stick x axis for whammy, while PS3 GH just uses the top half of the axis, and then rock band uses the entire axis but if you don't touch whammy it goes back to 0x7F after a second or so, much like how the selector switch works.

[AARP41298]

update

im trying to remap the xinput outside rpcs3 with xinputplus, durazno, x360ce, xoutput
in xoutput and x360 the remap works, but it takes 2 slots of xinput
xinput 1: original guitar
xinput 2: remaped guitar

xinputplus doesnt add the extra slot but the remapping options are too limited

i will experiment maping xinput to be used in rpcs like dinput

[AARP41298]

I kinda solve it
1 connect all the instruments (all xinputs are now filled)
2 open x360 and map only guitars
3 use the config*
4 enable mapped device
5 in rpcs3, gamepad settings, select SDL handler and use the "virtual" 360 controller

Now the guitars are mapped correctly

Thank you for the SDL handler

NOTE: the RB1 drums doesnt have button map issues you may simply use xinput

*config

PD Even calibrating the stick in DX Tweak i cant reach the flanger effect, but the solo modifier and overdrive gesture (starpower) work like charm

[TeaParty777]

Hi there!

I would like to add some info that maybe could be useful for more users.
Thanks to AARP41298 who started this solution.

I will leave my x360ce preset, FULLY WORKING!, all works as intended, the selector switch, the tilt for "STAR POWER", solo buttons which previosly needed strumming unless the selector switch was all the way down (like on the NONE setting).

https://www.mediafire.com/file/cjhzv62qd1oo0xy/PRESET_FENDER_RB2_WITH_XBOX_OFFICIAL_WIRELESS_RECEIVER_BY_FATALRACER.txt/file

another info:
Installed ViGEmBus 1.22.0 needed for x360ce to work.
x360ce v4.17.15.0 (2020-11-15)
Windows 11
Official Xbox 360 Wireless Receiver + Rock Band 2 Fender Stratocaster model: XBGTS2

https://www.youtube.com/watch?v=GDlJhniENw8

[KaijuChomps]

What I'm honestly curious to know is why in RPCS3, the Slider (detected as Left Trigger) only seems to even register for mapping purposes past the 70% point?

Would it be possible within RPCS3 ever to specific a specific range of the Slider to be mapped to RS Up and the other half to RS Down, to avoid both being triggered constantly by the inputs?

I know this is highly niche as an issue, but this does affect everyone using 360 Guitars to play Rock Band on RPCS3 right now, which is slowly increasing in the number of folks trying to figure it out.

[SArpnt]

the wii rockband guitar also maps these to the triggers instead of the joystick. it would be nice if i could add proper offsets and multipliers to each axis.

[Megamouse]

@AARP41298 try with #12384
See the description for how it works.
Save the pad settings once to get the new values in the config.
Then set these values here like this:

    Left Trigger Step Percent: 20
    Right Trigger Step Percent: 0
    Left Trigger Step Offset Percent: 10
    Right Trigger Step Offset Percent: 0

It should be in /config/input_configs/global/Default.yml unless you use a different pad config.

[Megamouse]

ah damn. I think I misunderstood the problem again xD.

[Megamouse]

I guess #15932 will fix it for real

[AARP41298]

Thank you @Megamouse, presing ALT to activate LT+ and LT- is perfect.
I still cant reach flanger effect, the same behaviour of x360ce, but now i can get rid of it, only map 3 things and we are ready to go.

If I remember correctly, a long time ago I needed to keep the whammy in the middle position in order to map the buttons, I see that is no longer necessary, thanks for that.

PD consider #14577

[Megamouse]

I don't understand what's the flanger effect and what the game expects.

[Megamouse]

It's possible that our implementation rounds to a slightly different value than the game would usually get from the device.

[sanjay900]

If it helps, the raw values from a PS3 rock band guitar and a 360 rock band guitar are listed here: https://github.com/TheNathannator/PlasticBand/blob/main/Docs/Instruments/5-Fret%20Guitar/Rock%20Band/General%20Notes.md The 360 and PS3 guitars do handle the middle option different, and I suspect that is the flanger so it makes sense that that might not map correct. The PS3 guitars shift the value for the flanger slightly to avoid conflicting with the neutral position, while the 360 guitars just use a value close to neutral. The PS3 guitars for some reason reset to neutral after a few seconds, while the 360 guitars never did this, which is why the 360 and PS3 guitars have this flanger discrepancy.

…

On Fri, 16 Aug 2024, 7:39 pm Megamouse, ***@***.***> wrote: It's possible that our implementation rounds to a slightly different value than the game would usually get from the device. — Reply to this email directly, view it on GitHub <#12384 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOGYQDXZJYL3GLET3B2LCLZRZBPRAVCNFSM54NQ6W32U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMRZGM4TQMJVGU4Q> . You are receiving this because you commented.Message ID: ***@***.***>

[Megamouse]

I've added a log message in #15956
When you get that build and map LT+ and LT- to the Right stick Y axis, you will see the corresponding values logged during gameplay.
Maybe they don't match with what you'd expect when setting selector switch to the positions.

[sanjay900]

@AARP41298
When you put the switch in the flanger position, does it act like nothing is selected? Or does it just keep the last position you selected

Also is it possible to get to the flanger setting by holding the switch in between wah wah and flanger?

[AARP41298]

@sanjay900

flanger.example.2.mp4

[Megamouse]

I've asked you guys to test my build and compare what's logged...

[sanjay900]

I've asked you guys to test my build and compare what's logged...

Sorry, I'm away on holiday at the moment and don't actually have access to a computer, so I was just asking questions out of curiosity to validate my thoughts on what was potentially happening.

[sanjay900]

Looking at that video though, I do believe you would need to have a specific patch for 360 guitars if you want the flanger to work on those, since the flanger value on 360 guitars certainly doesn't line up correctly in respect to what the game wants. Not sure how best to approach fixing that though

The Xbox guitars are using a value close to 0x7f, which is neutral on the PS3 ones, while the PS3 guitars want a value close to 0x96.

It's not a rounding problem I don't think, the instruments are just different between the consoles enough to throw it off.