Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Incorrect edit links on read the docs #122

Open
bkmgit opened this issue May 10, 2021 · 5 comments
Open

Incorrect edit links on read the docs #122

bkmgit opened this issue May 10, 2021 · 5 comments

Comments

@bkmgit
Copy link

bkmgit commented May 10, 2021

The GitHub edit links on read the docs are missing tree, as an example the link on https://rocmdocs.amd.com/en/latest/ is to https://github.com/RadeonOpenCompute/ROCm_Documentation//master/index.rst which resolves as not found. The correct link should be https://github.com/RadeonOpenCompute/ROCm_Documentation/tree/master/index.rst or https://github.com/RadeonOpenCompute/ROCm_Documentation/blob/master/index.rst

@jammm
Copy link

jammm commented Oct 3, 2021

I would hazard a guess that this this is due to a variable theme_vcs_pageview_mode being set to a blank string or something, causing a "...//..." to be in the URL instead of something like ".../blob/..."

It's a simple fix in this line https://github.com/RadeonOpenCompute/ROCm_Documentation/blob/master/_templates/breadcrumbs.html#L46
Either removing theme_vcs_pageview_mode or hard-coding to blob should do the trick.

Hey @Rmalavally, can we please fix this? I could try doing it myself but I'm not part of this org and would have to spend time to setup the environment etc as well, so it'd be great if someone can help :)

@Rmalavally
Copy link
Contributor

Thank you for your feedback. We are currently in the process of auditing ROCm content across multiple websites and have disabled the links for additional content updates.

Please send your feedback, changes, or corrections to roopa.malavally@amd.com. We will review the submissions and update our documentation accordingly. You may also reach out to the ROCm Support team, and they will raise internal tickets after review.

Sorry for any inconvenience. We will be back soon!

@jammm
Copy link

jammm commented Oct 4, 2021

Thank you for your quick reply! No worries at all. I really appreciate the work you guys are doing. :)
I'll send an email if there's any more feedback from me. Thanks!

@Rmalavally
Copy link
Contributor

Thank you for your kind comments. We feel encouraged.

We look forward to your feedback, @jammm.

@haydonryan
Copy link

Came here to post this - followed a link from the email "Introducing the World's Fastest HPC and AI Accelerator" sent yesterday.

Also, the explore more link in that email is now giving a connection refused.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants