Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we really need to have ExponentialFamilyManifolds.jl as dependency? #24

Closed
Nimrais opened this issue Jul 5, 2024 · 2 comments
Closed
Labels
dependencies Pull requests that update a dependency file question Further information is requested

Comments

@Nimrais
Copy link
Member

Nimrais commented Jul 5, 2024

However right now, we have a really mild constraints https://github.com/ReactiveBayes/ExponentialFamilyProjection.jl/blob/main/Project.toml#L32 it looks for me that we just do not need it here as dependency.

We use it only in two places

get_projected_to_manifold(prj::ProjectedTo) =
    ExponentialFamilyManifolds.get_natural_manifold(
        get_projected_to_type(prj),
        get_projected_to_dims(prj),
        get_projected_to_conditioner(prj),
    )
function preprocess_initialpoint(
    ::Type{T},
    initialpoint::ExponentialFamilyDistribution{T},
    M,
    parameters,
) where {T}
    return ExponentialFamilyManifolds.partition_point(
        M,
        copy(getnaturalparameters(initialpoint)),
    )
end

So maybe it's a reasonable solution is to create ExponetialManifoldsBase.jl define these two interfaces there and use ExponentialFamilyManifolds only as a test dependency.

@Nimrais Nimrais added question Further information is requested dependencies Pull requests that update a dependency file labels Jul 5, 2024
@bvdmitri
Copy link
Member

bvdmitri commented Jul 7, 2024

I don't see this as a problem. Using it in only two places isn't an issue because the library is already small. Creating another Base library doesn't seem to offer any immediate benefits. What specific problem are you aiming to solve?

@bvdmitri
Copy link
Member

Can be closed?

@Nimrais Nimrais closed this as completed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants