Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing rules Multiplication and Addition node #311

Closed
bartvanerp opened this issue Apr 18, 2023 · 4 comments · Fixed by #353
Closed

Missing rules Multiplication and Addition node #311

bartvanerp opened this issue Apr 18, 2023 · 4 comments · Fixed by #353
Assignees
Labels
bug Something isn't working

Comments

@bartvanerp
Copy link
Member

The Multiplication node misses some rules, which harm the user-friendliness.
These rules include (but might not be limited to)

(*)(::PointMass{<:Real}, ::MultivariateNormalDistributionsFamily)
(*)(::PointMass{<:UniformScaling}, ::MultivariateNormalDistributionsFamily)
@bartvanerp bartvanerp added the bug Something isn't working label Apr 18, 2023
@bartvanerp bartvanerp changed the title Missing rules Multiplication node Missing rules Multiplication and Addition node Apr 21, 2023
@bartvanerp
Copy link
Member Author

Also add

@rule typeof(+)(:in1, ReactiveMP.Marginalisation) (m_out::Missing, m_in2::PointMass) = m_out

@rule typeof(+)(:in1, ReactiveMP.Marginalisation) (m_out::Missing, m_in2::MvNormalMeanCovariance, ) = m_out

@rule typeof(*)(:in, ReactiveMP.Marginalisation) (m_out::Missing, m_A::PointMass, meta::ReactiveMP.TinyCorrection) = m_out

@bvdmitri
Copy link
Member

I'm a bit hesitant to add rules with Missing as an argument, because technically it is still a hacky way to pass empty observations and many other parts in ReactiveMP still do not play well with Missings (e.g. joint-marginals, average energy and entropies).

@bvdmitri
Copy link
Member

bvdmitri commented Oct 5, 2023

#248 adds rules with missings, do we still need the others?

@bartvanerp
Copy link
Member Author

I think they would still be nice to have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants