Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudwash needs more detailed logging. #119

Open
mayurilahane opened this issue Nov 13, 2023 · 3 comments
Open

Cloudwash needs more detailed logging. #119

mayurilahane opened this issue Nov 13, 2023 · 3 comments

Comments

@mayurilahane
Copy link
Contributor

Hi,
I have been using Cloudwash for couple of months.
And till now I have observed that it needs a detailed logging structure.
because as I was writing the Tekton pipeline for cleanup of Azure, AWS and GCP it always showed me this line at first and then it went on with the actual error.

(app-root) bash-5.2$ swach -d azure --all
<<<<<<< Running the cleanup script in DRY RUN mode >>>>>>>
The AZURE providers settings are initialized and validated !

and even if it wasn't able to fetch the secrets still it was saying "The AZURE providers settings are initialized and validated !" which i think is confusing.

So, now that I am testing my cron job locally with the help of minikube kubectl and everything is setup, resolved all of the error,
but now it just gives me above pasted LOC. and not the expected deletable resources.

So, I expect it to show me the full log.
Thanks !

@mayurilahane
Copy link
Contributor Author

cc: @mshriver

@mshriver
Copy link
Contributor

Looks like some overlap with the intent of #4, though I think its good for this to focus on the logging approach in general.

The types of improvements I would like to see include:

  • More debug level logging statements during provider query and resource filtering
  • log level control from the CLI
  • log level control via envvar (nice to have)
  • Removal of "settings validated" message, replace with confirmation of authenticated connection

@jyejare
Copy link
Collaborator

jyejare commented Nov 29, 2023

@mayurilahane @mshriver After debugging, looks like the regions setting value was not been seeded well to the tool. I agree though that the tool should have inform the same about this situation and inform that regions are must to proceed.

@mayurilahane You can contribute to log is the regions are missing either through info or through settings validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants