Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.1] EntityShapeContextMixin breaks Bumblezone's Suspicious Pile of Pollen brushing #13

Closed
TelepathicGrunt opened this issue Nov 13, 2023 · 1 comment
Assignees
Labels
bug Something isn't working upstream

Comments

@TelepathicGrunt
Copy link

I have been tracking down an issue with Canary, Sodium, and Radium in regards to this mixin making unsafe assumptions and breaking my mod with its null itemstack in EntityShapeContext.
https://github.com/Reforged-Hub/radium-upstream/blob/develop/src/main/java/me/jellysquid/mods/lithium/mixin/shapes/lazy_shape_context/EntityShapeContextMixin.java
TelepathicGrunt/Bumblezone#299

The sodium issue report with more info:
CaffeineMC#498 (comment)

I am working on a workaround by calling isHoldingItem early to force init the fields but I would like to ask you how do I disable Radium's mixins with my mod in a similar way to how Sodium and Canary allows me to disable the mixin. That way I can be sure this mixin doesn't break another mod's brushing automation code where they could construct their own EntityShapeContext and pass in a different item that the entity doesn't have.
https://github.com/CaffeineMC/lithium-fabric/wiki/Disabling-Lithium's-Mixins-using-your-mod's-fabric-mod.json
https://discord.com/channels/104299991589199872/752308882969329684/1173607719433936996

@TelepathicGrunt TelepathicGrunt added the bug Something isn't working label Nov 13, 2023
@dima-dencep
Copy link
Member

how do I disable Radium's mixins

https://github.com/Asek3/Oculus/blob/1.20/src/main/resources/META-INF/mods.toml#L22-L25

[mods."lithium:options"]
"mixin.shapes.lazy_shape_context"=false

@dima-dencep dima-dencep closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
Development

No branches or pull requests

3 participants