-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node v7 support? #121
Comments
Hey Hüseyin, |
actually there is. check this node-inspector/v8-profiler#99 and this |
hmm, yes, you are right, memory and cpu profiling won't work. However this problem does not affect other functionality such as tracing, APM, request metrics and the security feature. |
yes right now i do run track over 7.0.0 and exactly only memory & cpu profiling doesn't work. But what i think is that once v8-profiler bug is resolved, i guess it'll all good. I think it's a nice idea to track the issue. |
@szdavid92 any updates on this? |
|
and here is another build log from my ubuntu 14.04 + node 7.5 setup;
|
given another test with ubuntu 14.04 box;
installed using nvm. I've downloaded clean install of risingstack/v8-profiler;
then issued a build;
and it seems the fixes [https://github.com/RisingStack/v8-profiler/commit/81bb0321a3469c6625dcf687df43283fe6e288ac] actually are somehow ignored;
@gergelyke any ideas? |
found the issue, sent you a PR guys :) #129 |
Thanks @bonesoul . Good catch, we overlooked this :) |
any eta on it?
The text was updated successfully, but these errors were encountered: