Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to cargo criterion #190

Open
saik0 opened this issue Feb 9, 2022 · 2 comments
Open

Migrate to cargo criterion #190

saik0 opened this issue Feb 9, 2022 · 2 comments

Comments

@saik0
Copy link
Contributor

saik0 commented Feb 9, 2022

https://github.com/bheisler/cargo-criterion

  • cargo-criterion seeks to improve iteration time for Criterion-rs benchmarks. By moving functionality into a separate executable which can be installed once and reused, Criterion-rs can shrink - meaning less code to compile and link into the benchmarks themselves.
  • Because cargo-criterion can oversee the whole benchmark process from beginning to end, it's better placed to deliver features that would be difficult to implement in Criterion-rs. These include:
    - Machine-readable output
    - Tracking benchmarked performance over time

This is fantastic. Want. In addition to the above we can get rid of html-reports feature of criterion and bench will have much few dependencies -> faster CI builds.

@saik0 saik0 changed the title Migrate to cargo criterion Migrate to cargo criterion Feb 9, 2022
@Kerollmops
Copy link
Member

In addition to the above we can get rid of html-reports feature of criterion and bench will have much few dependencies

What do you mean by get rid of it? Do you mean that we will reduce our set of dependencies but will we keep the HTML reports? I hope so as they were easy to read, crawl, and understand.

@saik0
Copy link
Contributor Author

saik0 commented Feb 9, 2022

Right. cargo-criterion can generate all the reports. criterion can just be "just" the benchmark runner.

The idea is to have fewer build-deps for projects that use criterion, since it's lifted out to the cargo-criterion binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants