From 29a262ed7ececdfbf10f547c3147e6665537057e Mon Sep 17 00:00:00 2001
From: rocka <i@rocka.me>
Date: Mon, 14 Aug 2017 17:32:57 +0800
Subject: [PATCH] ui: tweak download button

* increase button margin
* reduce loading indicator size
* use vector icon
---
 app/src/main/res/drawable/ic_file_download.xml |  9 +++++++++
 app/src/main/res/layout/item_rom_package.xml   | 16 +++++++++-------
 app/src/main/res/values/dimens.xml             |  3 ++-
 3 files changed, 20 insertions(+), 8 deletions(-)
 create mode 100644 app/src/main/res/drawable/ic_file_download.xml

diff --git a/app/src/main/res/drawable/ic_file_download.xml b/app/src/main/res/drawable/ic_file_download.xml
new file mode 100644
index 0000000..370bba9
--- /dev/null
+++ b/app/src/main/res/drawable/ic_file_download.xml
@@ -0,0 +1,9 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"
+    android:width="24dp"
+    android:height="24dp"
+    android:viewportWidth="24.0"
+    android:viewportHeight="24.0">
+    <path
+        android:fillColor="#FF000000"
+        android:pathData="M19,9h-4V3H9v6H5l7,7 7,-7zM5,18v2h14v-2H5z" />
+</vector>
diff --git a/app/src/main/res/layout/item_rom_package.xml b/app/src/main/res/layout/item_rom_package.xml
index aac1c4e..94ed9f1 100644
--- a/app/src/main/res/layout/item_rom_package.xml
+++ b/app/src/main/res/layout/item_rom_package.xml
@@ -38,19 +38,21 @@
         <ProgressBar
             android:id="@+id/progress_circle_download"
             style="?android:attr/progressBarStyle"
-            android:layout_width="@dimen/download_btn_width"
-            android:layout_height="@dimen/download_btn_width"
-            android:layout_marginEnd="@dimen/download_btn_margin"
+            android:layout_width="@dimen/download_idc_width"
+            android:layout_height="@dimen/download_idc_width"
+            android:layout_marginBottom="@dimen/download_btn_margin"
+            android:layout_marginEnd="13dp"
             android:layout_marginTop="@dimen/download_btn_margin"
             android:alpha="0.0"
+            app:layout_constraintBottom_toBottomOf="parent"
             app:layout_constraintEnd_toEndOf="parent"
-            app:layout_constraintTop_toTopOf="parent"
-            app:srcCompat="@android:drawable/stat_sys_download" />
+            app:layout_constraintTop_toTopOf="parent" />
 
         <ImageButton
             android:id="@+id/button_download"
             android:layout_width="@dimen/download_btn_width"
             android:layout_height="@dimen/download_btn_width"
+            android:layout_marginBottom="@dimen/download_btn_margin"
             android:layout_marginEnd="@dimen/download_btn_margin"
             android:layout_marginTop="@dimen/download_btn_margin"
             android:background="@android:color/transparent"
@@ -58,10 +60,10 @@
             android:contentDescription="@string/desc_download_btn"
             android:focusable="true"
             android:foreground="?attr/selectableItemBackground"
-            android:padding="8dp"
             android:tint="@color/colorPrimary"
+            app:layout_constraintBottom_toBottomOf="parent"
             app:layout_constraintEnd_toEndOf="parent"
             app:layout_constraintTop_toTopOf="parent"
-            app:srcCompat="@android:drawable/stat_sys_download" />
+            app:srcCompat="@drawable/ic_file_download" />
     </android.support.constraint.ConstraintLayout>
 </layout>
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
index a65db2a..a386017 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -1,5 +1,6 @@
 <resources>
     <dimen name="fab_margin">16dp</dimen>
-    <dimen name="download_btn_width">40dp</dimen>
+    <dimen name="download_btn_width">42dp</dimen>
+    <dimen name="download_idc_width">32dp</dimen>
     <dimen name="download_btn_margin">8dp</dimen>
 </resources>