Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NameIDFormat - PascalCase? #402

Open
eljeffeg opened this issue Mar 28, 2024 · 2 comments
Open

NameIDFormat - PascalCase? #402

eljeffeg opened this issue Mar 28, 2024 · 2 comments

Comments

@eljeffeg
Copy link

So every setting key name is CamelCase except NameIDFormat. Is there a particular reason for this?
I'm building a connector and due to ES, the settings need to be snake_case: https://www.elastic.co/guide/en/ecs/current/ecs-guidelines.html#_guidelines_for_field_names

So I have to convert them all from snake case to camel case for python3-saml, but for one exception that doesn't follow the rule. Anyway.. figured I'd grumble. haha

@eljeffeg
Copy link
Author

eljeffeg commented Mar 28, 2024

And the organization country codes en-US, Kebab Case? 🤦

@pitbulk
Copy link
Contributor

pitbulk commented Jun 26, 2024

I think I can fix that and support both NameIDFormat and NameIdFormat.

And related to the use of 'en-US' as country code, I see its use in many many places, for example see this page where Metadata elements are described, it uses 'en-US'

but you can use whatever lang code as part of the info for the Organizational Data you inject in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants