From 776ade69b3ffd6f3d83bcf5255e94c4c1875cc20 Mon Sep 17 00:00:00 2001 From: johnnyshields <27655+johnnyshields@users.noreply.github.com> Date: Mon, 8 Jul 2024 18:29:41 +0900 Subject: [PATCH] Mark all rubocops pending --- .rubocop_todo.yml | 148 +++++++++++++++++++++++++++++++++++++--------- Gemfile | 6 +- 2 files changed, 122 insertions(+), 32 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 131a5f49..1daf9bf4 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,12 +1,12 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2023-03-08 09:38:19 UTC using RuboCop version 1.45.1. +# on 2024-07-08 09:28:53 UTC using RuboCop version 1.64.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 18 +# Offense count: 19 # This cop supports safe autocorrection (--autocorrect). Layout/EmptyLineAfterGuardClause: Exclude: @@ -14,12 +14,13 @@ Layout/EmptyLineAfterGuardClause: - 'lib/onelogin/ruby-saml/idp_metadata_parser.rb' - 'lib/onelogin/ruby-saml/logoutrequest.rb' - 'lib/onelogin/ruby-saml/logoutresponse.rb' + - 'lib/onelogin/ruby-saml/metadata.rb' - 'lib/onelogin/ruby-saml/response.rb' - 'lib/onelogin/ruby-saml/saml_message.rb' - 'lib/onelogin/ruby-saml/slo_logoutrequest.rb' - 'lib/onelogin/ruby-saml/slo_logoutresponse.rb' -# Offense count: 10 +# Offense count: 9 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only @@ -33,6 +34,12 @@ Layout/EmptyLinesAroundClassBody: - 'lib/onelogin/ruby-saml/slo_logoutresponse.rb' - 'lib/xml_security.rb' +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Layout/EmptyLinesAroundMethodBody: + Exclude: + - 'lib/onelogin/ruby-saml/slo_logoutrequest.rb' + # Offense count: 12 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. @@ -59,15 +66,13 @@ Layout/EndOfLine: Exclude: - 'lib/onelogin/ruby-saml/setting_error.rb' -# Offense count: 5 +# Offense count: 3 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment. Layout/ExtraSpacing: Exclude: - - 'lib/onelogin/ruby-saml/authrequest.rb' - 'lib/onelogin/ruby-saml/logoutrequest.rb' - 'lib/onelogin/ruby-saml/response.rb' - - 'lib/onelogin/ruby-saml/slo_logoutresponse.rb' # Offense count: 6 # This cop supports safe autocorrection (--autocorrect). @@ -125,15 +130,14 @@ Layout/SpaceAroundEqualsInParameterDefault: - 'lib/onelogin/ruby-saml/response.rb' - 'lib/onelogin/ruby-saml/utils.rb' -# Offense count: 18 +# Offense count: 16 # This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator. +# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator, EnforcedStyleForRationalLiterals. # SupportedStylesForExponentOperator: space, no_space +# SupportedStylesForRationalLiterals: space, no_space Layout/SpaceAroundOperators: Exclude: - - 'lib/onelogin/ruby-saml/authrequest.rb' - 'lib/onelogin/ruby-saml/response.rb' - - 'lib/onelogin/ruby-saml/slo_logoutresponse.rb' - 'lib/onelogin/ruby-saml/utils.rb' - 'lib/xml_security.rb' @@ -147,7 +151,7 @@ Layout/SpaceInsideBlockBraces: - 'lib/onelogin/ruby-saml/idp_metadata_parser.rb' - 'lib/onelogin/ruby-saml/utils.rb' -# Offense count: 41 +# Offense count: 37 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # SupportedStyles: space, no_space, compact @@ -156,13 +160,12 @@ Layout/SpaceInsideHashLiteralBraces: Exclude: - 'lib/onelogin/ruby-saml/authrequest.rb' - 'lib/onelogin/ruby-saml/logoutrequest.rb' - - 'lib/onelogin/ruby-saml/metadata.rb' - 'lib/onelogin/ruby-saml/response.rb' - 'lib/onelogin/ruby-saml/settings.rb' - 'lib/onelogin/ruby-saml/slo_logoutresponse.rb' - 'lib/xml_security.rb' -# Offense count: 3 +# Offense count: 4 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: final_newline, final_blank_line @@ -170,6 +173,7 @@ Layout/TrailingEmptyLines: Exclude: - 'lib/onelogin/ruby-saml/http_error.rb' - 'lib/onelogin/ruby-saml/setting_error.rb' + - 'lib/onelogin/ruby-saml/settings.rb' - 'lib/onelogin/ruby-saml/validation_error.rb' # Offense count: 4 @@ -185,10 +189,14 @@ Lint/NoReturnInBeginEndBlocks: Exclude: - 'lib/onelogin/ruby-saml/idp_metadata_parser.rb' -# Offense count: 1 -Lint/ShadowingOuterLocalVariable: +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: strict, consistent +Lint/SymbolConversion: Exclude: - - 'lib/onelogin/ruby-saml/response.rb' + - 'lib/onelogin/ruby-saml/idp_metadata_parser.rb' + - 'lib/onelogin/ruby-saml/settings.rb' # Offense count: 1 # Configuration parameters: AllowedPatterns. @@ -198,12 +206,14 @@ Lint/UnreachableLoop: - 'lib/onelogin/ruby-saml/saml_message.rb' # Offense count: 3 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: AutoCorrect. Lint/UselessAssignment: Exclude: - 'lib/onelogin/ruby-saml/logging.rb' - - 'lib/onelogin/ruby-saml/response.rb' + - 'lib/onelogin/ruby-saml/slo_logoutrequest.rb' -# Offense count: 39 +# Offense count: 42 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes. Metrics/AbcSize: Max: 100 @@ -219,12 +229,12 @@ Metrics/BlockLength: Metrics/ClassLength: Max: 652 -# Offense count: 23 +# Offense count: 25 # Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/CyclomaticComplexity: Max: 21 -# Offense count: 58 +# Offense count: 59 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. Metrics/MethodLength: Max: 63 @@ -234,12 +244,12 @@ Metrics/MethodLength: Metrics/ParameterLists: MaxOptionalParameters: 4 -# Offense count: 22 +# Offense count: 24 # Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/PerceivedComplexity: Max: 22 -# Offense count: 7 +# Offense count: 13 Naming/AccessorMethodName: Exclude: - 'lib/onelogin/ruby-saml/settings.rb' @@ -251,17 +261,19 @@ Naming/AccessorMethodName: # AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS Naming/FileName: Exclude: + - 'Rakefile.rb' - 'lib/onelogin/ruby-saml.rb' - 'lib/ruby-saml.rb' # Offense count: 2 +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyleForLeadingUnderscores. # SupportedStylesForLeadingUnderscores: disallowed, required, optional Naming/MemoizedInstanceVariableName: Exclude: - 'lib/onelogin/ruby-saml/response.rb' -# Offense count: 3 +# Offense count: 4 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. # NamePrefix: is_, has_, have_ # ForbiddenPrefixes: is_, has_, have_ @@ -294,6 +306,13 @@ Performance/CollectionLiteralInLoop: Exclude: - 'lib/onelogin/ruby-saml/response.rb' +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: AllowRegexpMatch. +Performance/RedundantEqualityComparisonBlock: + Exclude: + - 'lib/onelogin/ruby-saml/settings.rb' + # Offense count: 5 # This cop supports unsafe autocorrection (--autocorrect-all). Performance/StringInclude: @@ -325,7 +344,7 @@ Style/AccessorGrouping: - 'lib/onelogin/ruby-saml/settings.rb' - 'lib/onelogin/ruby-saml/slo_logoutrequest.rb' -# Offense count: 5 +# Offense count: 6 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: prefer_alias, prefer_alias_method @@ -333,6 +352,7 @@ Style/Alias: Exclude: - 'lib/onelogin/ruby-saml/attributes.rb' - 'lib/onelogin/ruby-saml/response.rb' + - 'lib/onelogin/ruby-saml/settings.rb' - 'lib/onelogin/ruby-saml/slo_logoutrequest.rb' # Offense count: 13 @@ -361,6 +381,7 @@ Style/ConditionalAssignment: - 'lib/onelogin/ruby-saml/authrequest.rb' - 'lib/onelogin/ruby-saml/logoutresponse.rb' - 'lib/onelogin/ruby-saml/response.rb' + - 'lib/onelogin/ruby-saml/slo_logoutrequest.rb' - 'lib/xml_security.rb' # Offense count: 8 @@ -375,26 +396,47 @@ Style/Documentation: - 'lib/onelogin/ruby-saml/logging.rb' - 'lib/xml_security.rb' -# Offense count: 1 +# Offense count: 2 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: MinBodyLength, AllowConsecutiveConditionals. Style/GuardClause: Exclude: - 'lib/onelogin/ruby-saml/response.rb' + - 'lib/onelogin/ruby-saml/settings.rb' + +# Offense count: 3 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: AllowedReceivers. +# AllowedReceivers: Thread.current +Style/HashEachMethods: + Exclude: + - 'lib/onelogin/ruby-saml/metadata.rb' + - 'lib/onelogin/ruby-saml/settings.rb' + +# Offense count: 4 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. +# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys +# SupportedShorthandSyntax: always, never, either, consistent, either_consistent +Style/HashSyntax: + Exclude: + - 'lib/onelogin/ruby-saml/settings.rb' -# Offense count: 60 +# Offense count: 66 # This cop supports safe autocorrection (--autocorrect). Style/IfUnlessModifier: Exclude: - 'lib/onelogin/ruby-saml/authrequest.rb' - 'lib/onelogin/ruby-saml/error_handling.rb' - 'lib/onelogin/ruby-saml/idp_metadata_parser.rb' + - 'lib/onelogin/ruby-saml/logoutrequest.rb' - 'lib/onelogin/ruby-saml/logoutresponse.rb' - 'lib/onelogin/ruby-saml/metadata.rb' - 'lib/onelogin/ruby-saml/response.rb' - 'lib/onelogin/ruby-saml/saml_message.rb' - 'lib/onelogin/ruby-saml/settings.rb' - 'lib/onelogin/ruby-saml/slo_logoutrequest.rb' + - 'lib/onelogin/ruby-saml/slo_logoutresponse.rb' - 'lib/onelogin/ruby-saml/utils.rb' - 'lib/xml_security.rb' @@ -413,15 +455,47 @@ Style/OptionalBooleanParameter: - 'lib/onelogin/ruby-saml/utils.rb' - 'lib/xml_security.rb' -# Offense count: 2 +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantBegin: + Exclude: + - 'lib/onelogin/ruby-saml/utils.rb' + +# Offense count: 8 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantRegexpArgument: + Exclude: + - 'lib/onelogin/ruby-saml/saml_message.rb' + - 'lib/onelogin/ruby-saml/utils.rb' + - 'lib/xml_security.rb' + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, AllowInnerSlashes. +# SupportedStyles: slashes, percent_r, mixed +Style/RegexpLiteral: + Exclude: + - 'lib/onelogin/ruby-saml/response.rb' + - 'lib/onelogin/ruby-saml/slo_logoutrequest.rb' + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength. +# AllowedMethods: present?, blank?, presence, try, try! +Style/SafeNavigation: + Exclude: + - 'lib/onelogin/ruby-saml/slo_logoutrequest.rb' + +# Offense count: 4 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Mode. Style/StringConcatenation: Exclude: - 'lib/onelogin/ruby-saml/response.rb' - 'lib/onelogin/ruby-saml/saml_message.rb' + - 'lib/onelogin/ruby-saml/slo_logoutrequest.rb' -# Offense count: 450 +# Offense count: 443 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes @@ -443,7 +517,23 @@ Style/StringLiterals: - 'lib/onelogin/ruby-saml/utils.rb' - 'lib/xml_security.rb' -# Offense count: 100 +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +Style/SuperArguments: + Exclude: + - 'lib/onelogin/ruby-saml/authrequest.rb' + - 'lib/onelogin/ruby-saml/logoutrequest.rb' + - 'lib/onelogin/ruby-saml/slo_logoutresponse.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, MinSize. +# SupportedStyles: percent, brackets +Style/SymbolArray: + Exclude: + - 'lib/onelogin/ruby-saml/settings.rb' + +# Offense count: 103 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns. # URISchemes: http, https diff --git a/Gemfile b/Gemfile index 05ecdf93..cfbda3cd 100644 --- a/Gemfile +++ b/Gemfile @@ -7,9 +7,9 @@ gemspec gem 'minitest', '~> 5.18', require: false gem 'mocha', '~> 2.0', require: false gem 'rake', '~> 13.0' -gem 'rubocop', '~> 1.45.1', require: false -gem 'rubocop-minitest', '~> 0.22.2', require: false -gem 'rubocop-performance', '~> 1.16.0', require: false +gem 'rubocop', '~> 1.64.1', require: false +gem 'rubocop-minitest', '~> 0.35.0', require: false +gem 'rubocop-performance', '~> 1.21.1', require: false gem 'rubocop-rake', '~> 0.6.0', require: false gem 'simplecov', '~> 0.22', require: false gem 'simplecov-lcov', '~> 0.8', require: false