Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EvaluationResult of Negative Binomial number test should return variance / alpha #261

Open
pabloitu opened this issue Aug 19, 2024 · 0 comments · May be fixed by #263
Open

EvaluationResult of Negative Binomial number test should return variance / alpha #261

pabloitu opened this issue Aug 19, 2024 · 0 comments · May be fixed by #263
Assignees

Comments

@pabloitu
Copy link
Collaborator

The evaluation function

def negative_binomial_number_test(gridded_forecast, observed_catalog, variance):
requires a variance parameter. However, this is not stored in the resulting EvaluationResult. To plot this negative binomial consistency test, the variance parameter is required again, which impedes the EvaluationResult to be a standalone object without the function arguments that created it. I propose to change
result.test_distribution = ('negative_binomial', fore_cnt)
to

    result.test_distribution = ('negative_binomial', fore_cnt, variance)

This would imply to remove the variance argument from the plot_consistency_test signature and retrieve it from the EvaluationResult argument the plot function has.

@pabloitu pabloitu mentioned this issue Aug 19, 2024
16 tasks
@pabloitu pabloitu self-assigned this Aug 20, 2024
@pabloitu pabloitu linked a pull request Aug 27, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant