Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer #4

Open
JoannaSendecka opened this issue Apr 29, 2024 · 1 comment
Open

Footer #4

JoannaSendecka opened this issue Apr 29, 2024 · 1 comment

Comments

@JoannaSendecka
Copy link
Collaborator

The footer is expected to have two logos with corresponding text.

Problem 1: Currently when we change the window size they icons stay too large and the layout is distorted.
First solution will be to add relevant text to the logos and save it as images that will be used instead (Joanna will create the images).

Problem 2: the images in footer feed from the code (_includes/default/footer.liquid) that includes the path site.footer_text. That means that the path changes for every subpage.
Current solution was to create the folder with a copy of logotypes for every subpage (e.g. contact/assets/img), but it should feed from one source i.e. assets/img folder for all of the subpages.

Settings:
_config.yml
index.html
_includes/default/footer.liquid
_sass/includes/_footer.scss

@JoannaSendecka
Copy link
Collaborator Author

Images were changed to have the text within

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant