Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is a single AFFIX component or every component responsible for the connection name/locator? #23

Open
monzum opened this issue Nov 22, 2013 · 1 comment
Labels

Comments

@monzum
Copy link
Contributor

monzum commented Nov 22, 2013

In our implementation currently, only the Coordination AFFIX is responsible for the name. We provide the name/locator as one of the arguments for the Coordination AFFIX. This value does not get passed on to the other AFFIX components. Is this the correct way of doing it?

Furthermore, when we create an AFFIX stack through the AffixStackInterface, we provide an argument for the virtual_host_name which is used when the AFFIX stack is created. However this argument is not used for any other purpose other than AffixStack.gethostname() that returns this value.

The reason I originally did not pass the virtual_host_name to individual components is to ensure that the components did not change the name and return an ambiguous value when the method getmyip() is invoked.

Any thoughts on what should be done here? Should the virtual_host_name provided by the application be made available to all the AFFIX components or just to the AFFIX stack? If we do not make it available to every AFFIX component than a name will need to be passed down to decider and branching/splitter AFFIXs such as Coordination AFFIX and Legacy AFFIX.

@JustinCappos
Copy link
Contributor

Let's discuss in the google doc.

On Fri, Nov 22, 2013 at 12:22 PM, monzum notifications@github.com wrote:

In our implementation currently, only the Coordination AFFIX is
responsible for the name. We provide the name/locator as one of the
arguments for the Coordination AFFIX. This value does not get passed on to
the other AFFIX components. Is this the correct way of doing it?

Furthermore, when we create an AFFIX stack through the
AffixStackInterface, we provide an argument for the virtual_host_name which
is used when the AFFIX stack is created. However this argument is not used
for any other purpose other than AffixStack.gethostname() that returns this
value.

The reason I originally did not pass the virtual_host_name to individual
components is to ensure that the components did not change the name and
return an ambiguous value when the method getmyip() is invoked.

Any thoughts on what should be done here? Should the virtual_host_name
provided by the application be made available to all the AFFIX components
or just to the AFFIX stack? If we do not make it available to every AFFIX
component than a name will need to be passed down to decider and
branching/splitter AFFIXs such as Coordination AFFIX and Legacy AFFIX.


Reply to this email directly or view it on GitHubhttps://github.com//issues/23
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants