Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoordinationAffix stacks components below it #55

Open
aaaaalbert opened this issue Jul 29, 2014 · 0 comments
Open

CoordinationAffix stacks components below it #55

aaaaalbert opened this issue Jul 29, 2014 · 0 comments

Comments

@aaaaalbert
Copy link
Contributor

Here's a problem I saw on my MacBook Pro 10.6.8 when my node when offline and then online a couple of times. CoordinationAffix doesn't remove the components below it before it before it builds a "new" stack. In the example below we thus have multiple TCPRelayAffixes, most of them dead.

CoordinationAffix: Advertised c2a76dc744eb402b89ea5ff625e86456ef228d60,1224,TCP (TCPRelayAffix,131.130.125.5:63140)(TCPRelayAffix,131.130.125.5:63150)(TCPRelayAffix,131.130.125.5:63160)(TCPRelayAffix,131.130.125.5:63150)(NamingAndResolverAffix)

Note: I haven't seen this behavior on Android yet.
aaaaalbert added a commit to SensibilityTestbed/nodemanager that referenced this issue Apr 8, 2016
@aaaaalbert
Move Affix instantion into ports-checking logic
0535e0f 
This ensures that no pre-existing Affix stack instance is reused
when the connectivity flaps. Also "solves" SeattleTestbed/affix#55
as the CoordinationAffix isn't reused. (The question remains if
reuse should be allowed in general -- if so, then an Affix component
must clean up state when exceptions occur.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaaaalbert