Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsequent use of helper function in node_transition_lib #141

Open
aaaaalbert opened this issue Sep 4, 2014 · 0 comments
Open

Inconsequent use of helper function in node_transition_lib #141

aaaaalbert opened this issue Sep 4, 2014 · 0 comments
Labels
newcomer

Comments

@aaaaalbert
Copy link
Contributor

https://github.com/SeattleTestbed/clearinghouse/blob/master/node_state_transitions/node_transition_lib.py defines a helper function, _do_rsa_publickey_to_string, which is used in place of the "original" call from rsa.r2py. The helper function is not used throughout however (i.e. doesn't replace every call to rsa's), and I don't understand why it exists in the first place.

Please refactor!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
newcomer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaaaalbert