Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor library function names? #176

Open
aaaaalbert opened this issue Aug 20, 2015 · 1 comment
Open

Refactor library function names? #176

aaaaalbert opened this issue Aug 20, 2015 · 1 comment
Labels

Comments

@aaaaalbert
Copy link
Contributor

In RepyV1, module "imports" were actually inlined using the Repy preprocessor repypp. Module functions were always prefixed with the module name, e.g. advertise_lookup, so that no inadvertent aliasing / name collisions occur. In RepyV2, dylink lets us import modules much like Python's import modulename (see also #137), so we don't need the un-aliasing anymore.

I suggest we refactor the function names across modules to drop the module-name prefix. What do others think?

@JustinCappos
Copy link
Contributor

Yes, this seems like a good idea to me.

Another option is to also alias the names when dylink does the import...

On Thu, Aug 20, 2015 at 12:08 PM, aaaaalbert notifications@github.com
wrote:

In RepyV1, module "imports" were actually inlined using the Repy
preprocessor repypp. Module functions were always prefixed with the
module name, e.g. advertise_lookup, so that no inadvertent aliasing /
name collisions occur. In RepyV2, dylink lets us import modules much like
Python's import modulename (see also #137
#137), so we
don't need the un-aliasing anymore.

I suggest we refactor the function names across modules to drop the
module-name prefix. What do others think?


Reply to this email directly or view it on GitHub
#176.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants