Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The back arrow/button behavior in CheckoutDialog cannot be overriden #135

Open
marcinKdev opened this issue Oct 11, 2024 · 2 comments
Open
Labels
Bug Something isn't working untriaged The issue has not yet been checked by the team

Comments

@marcinKdev
Copy link

What area is the issue related to?

Checkout Sheet Kit

What version of the package are you using?

3.1.1

Reproducible sample code

We are displaying the CheckoutSheetKit in a recommended way from the level of MainActivity in our app:
ShopifyCheckoutSheetKit.present(url, this, shopifyCheckoutSheetEventsProcessor)

and the checkout window that pops up over the screen contains two buttons on top. The "X" button works well but the back arrow does not work at when I tap on it:

Image

Steps to Reproduce

Display the checkout overlay in a way desribed in SDK README like

fun presentCheckout() { val checkoutUrl = cart.checkoutUrl ShopifyCheckoutSheetKit.present(checkoutUrl, context, checkoutEventProcessor) }

Note the back arrow of the checkout dialog not working.

Expected Behavior

SDK should provide a way to override the behavior of the back arrow to hide it

Actual Behavior

Back arrow is not operational, there's no way to override its behavior or hide it

Screenshots/Videos/Log output

No response

Storefront domain

westwing-main-prod.myshopify.com

@marcinKdev marcinKdev added Bug Something isn't working untriaged The issue has not yet been checked by the team labels Oct 11, 2024
@kiftio
Copy link
Contributor

kiftio commented Oct 11, 2024

Hi @marcinKdev I wouldn't normally expect the back/up button to be visible on the dialog's toolbar. I'd like to try to reproduce it. If you're able to answer any of these it could help speed that up:

  • What class does your MainActivity extend (AppCompatActivity, ComponentActivity, etc)?
  • As you said it's the MainActivity, I assume it doesn't have a parent?
  • Do you set a toolbar as an action bar / app bar anywhere?
  • Do you use a theme that includes an action bar?
  • Do you access or redefine anything with this ID R.id.checkoutSdkHeader?

Thanks!

E.g. screenshot from the MobileBuyIntegration sample (with a custom title)
Image

@kiftio
Copy link
Contributor

kiftio commented Oct 18, 2024

Hi @marcinKdev did you manage to figure this out? Or are you able to provide any of the above info?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working untriaged The issue has not yet been checked by the team
Projects
None yet
Development

No branches or pull requests

2 participants