-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
video_tag fallback image missing alt attribute #1720
Comments
...and why is there an image tag inside the video tag anyways? It doesn't render on any browsers if the poster is empty. Is it necessary and/or semantic? |
@Shopify could we please get this one actioned? It should be a simple change and is then consistent with |
Can this be fixed pelase? |
Found this while doing an ADA audit today, still an ongoing issue. |
Ran into this as well recently. This may depend on your theme, but after uploading the video in the theme customizer, you can click on the video thumbnail and a black overlay will appear. In that screen there is a space for alt text. This fixed my issue. |
This is still an issue. Ideally is should be possible to pass an empty alt value or custom. |
+1 In Lighthouse 12.2.0 when the video is below the fold the The spec for video poster in Liquid either needs to be fixed or expanded to allow us to:
This is not the way 👇 {% capture video_elem %}
{{ video | video_tag: playsinline: '', muted: '', loop: '' }}
{% endcapture %}
{% if section.index < 2 %}
{% comment %} make poster lazy {% endcomment %}
{% assign video_elem = video_elem | replace: '<img', '<img loading="lazy"' %}
{% endif %}
{{ video_elem }} |
video_tag
fallback image missing alt attribute and triggering Lighthouse accessibility error:https://shopify.dev/docs/api/liquid/filters/video_tag
The text was updated successfully, but these errors were encountered: