Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit column defintions - Add NULL constraints and indexes #154

Open
jomey opened this issue Oct 10, 2024 · 0 comments
Open

Revisit column defintions - Add NULL constraints and indexes #154

jomey opened this issue Oct 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jomey
Copy link
Member

jomey commented Oct 10, 2024

Most of our column definitions don't have the null constraint.
For example - an instrument can be currently be added without a name.
This can be improved by adding

Column(String(), nullable=False)

Second review while doing a swoop through the tables is to check for needed indexes.
From the above example, it would also be good to have an index on names since that is a very frequent query we will have

Column(String(), nullable=False, index=True)
@jomey jomey added the enhancement New feature or request label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant