Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No notification for "autorelease available" #3

Open
coinop-logan opened this issue Oct 10, 2018 · 0 comments
Open

No notification for "autorelease available" #3

coinop-logan opened this issue Oct 10, 2018 · 0 comments

Comments

@coinop-logan
Copy link
Collaborator

The BurnablePayment contract doesn't actually do any processing when the autorelease becomes available to the worker; the only thing that makes it "available" is that the require condition in triggerAutorelease "require(now >= autoreleaseTime)" will pass.

Because there is no processing, and no event triggered, the server currently has no way of knowing when this happens. This is unfortunate from a user experience perspective; a Buyer has an obvious interest in knowing that he can trigger the autorelease. A related feature would be to send out notifications when the autorelease is "coming soon"; this has utility for the Seller.

This isn't exactly trivial to set up though. The server would need to perform the above mentioned condition manually. Also, as things are currently written, there is an assumption that each notification originates from an event... Adding this feature violates that assumption, which means something will have to be rebuilt (for example, the "notifyParties" function takes an address and an event, but here there is no event).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant