Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Our current CI/CD for code formatting is broken #80

Open
iuliaturc opened this issue Oct 11, 2024 · 1 comment
Open

[BUG] Our current CI/CD for code formatting is broken #80

iuliaturc opened this issue Oct 11, 2024 · 1 comment
Labels
bug Something isn't working 🔥 difficulty: 2 Quite easy good first issue Good for newcomers hacktoberfest Open to Hacktoberfest contributions

Comments

@iuliaturc
Copy link
Contributor

iuliaturc commented Oct 11, 2024

Describe the bug
Currently, the automation we have for code formatting here is broken in most cases.

My intention was to have an automation that runs isort and black --line-length=120 on every PR and adds a commit with formatted code. However:

  • It actually fails most of the time
  • It can't run on public PRs, needs the approval of the maintainers

To Reproduce
You can look at the history of actions, and see that it fails for various reasons (see example).

Expected behavior

  • The less error-prone thing would be to have it run the formatting, but not attempt to make an actual commit.
  • After removing the automated commit, we should make it easy for developers to run these formatting tools themselves by providing e.g. .vscode defaults.
  • You can take inspiration from this GPT response and feel free to take liberties if you think there's a better practice here.
@iuliaturc iuliaturc changed the title [BUG] Your bug title here. [BUG] Our current CI/CD for code formatting is broken Oct 11, 2024
@iuliaturc iuliaturc added good first issue Good for newcomers hacktoberfest Open to Hacktoberfest contributions 🔥 difficulty: 2 Quite easy bug Something isn't working labels Oct 11, 2024
@laksh-krishna-sharma
Copy link

Hi @iuliaturc , may i work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🔥 difficulty: 2 Quite easy good first issue Good for newcomers hacktoberfest Open to Hacktoberfest contributions
Projects
None yet
Development

No branches or pull requests

2 participants