Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError: 'ListmodeToSinograms' object has no attribute 'prompts_and_randoms_from_listmode' #8

Closed
paskino opened this issue Jun 6, 2024 · 3 comments
Assignees
Labels

Comments

@paskino
Copy link
Contributor

paskino commented Jun 6, 2024

I built SIRF 3.7.0 with the branch SyneRBI/SIRF-SuperBuild#897

Executing https://github.com/SyneRBI/Challenge24/blob/nema-data/src/SIRF_data_preparation/prepare_data.py it fails with the following AttributeError which is correct for ListmodeToSinograms

ERROR: ProjDataFromStream: error reading data
0.0

INFO: CListModeDataECAT8_32bit: opening file /home/jovyan/work/Challenge24/src/SIRF_data_preparation/../../../ChallengeData/PET/mMR/NEMA_IQ/20170809_NEMA_60min_UCL.l
Traceback (most recent call last):
  File "/home/jovyan/work/Challenge24/src/SIRF_data_preparation/prepare_data.py", line 25, in <module>
    prepare_challenge_data(data_path, sirf_data_path, challenge_data_path, intermediate_data_path, '20170809_NEMA_',
  File "/home/jovyan/work/Challenge24/lib/sirf_exercises/__init__.py", line 115, in prepare_challenge_data
    prompts, randoms = lm2sino.prompts_and_randoms_from_listmode(listmode_data, 0, 10, acq_data_template)
AttributeError: 'ListmodeToSinograms' object has no attribute 'prompts_and_randoms_from_listmode'
@evgueni-ovtchinnikov
Copy link
Contributor

@paskino looks like your SIRF branch is either not ch2sirf or not recent - run git fetch and git branch in any SIRF folder, please

@paskino
Copy link
Contributor Author

paskino commented Jun 6, 2024

SIRF branch is v3.7.0 and it is not sufficient. As you suggest, what's needed is code from ch2sirf but that is not up-to-date with SIRF 3.7. I created a PR to update it, SyneRBI/SIRF#1262

@paskino
Copy link
Contributor Author

paskino commented Jun 6, 2024

close as necessary code is found

@paskino paskino closed this as completed Jun 6, 2024
@casperdcl casperdcl added the data label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants