Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated "libpng" Library Contains Known Security Flaw #4

Open
hsa1280 opened this issue Aug 23, 2021 · 3 comments
Open

Outdated "libpng" Library Contains Known Security Flaw #4

hsa1280 opened this issue Aug 23, 2021 · 3 comments

Comments

@hsa1280
Copy link

hsa1280 commented Aug 23, 2021

Hello,

I am using https://github.com/wonday/react-native-pdf for pdf display. This package uses AndroidPdfViewer to handle PDF display on Android. I got this error with secure report:
Outdated "libpng" Library Contains Known Security Flaw

The libpng version I am using is 1.6.22.

The recommended fix is to use libpng of 1.6.32 or greater, which version of libpng are you using in your package and when do you plan to upgrade if it is below 1.6.22?

Thank you and looking forward to your reply.

@TalbotGooday
Copy link
Owner

Hello! Sorry for the long answer.
Actually I didn't plan to update anything since I made this fork, migrated to the AndroidX and fixed some crashes. I just don't have enough time to do this.
BUT, if you will open a PR here with updated libpng lib I will create an update.
Thanks for understanding 😅

@hsa1280
Copy link
Author

hsa1280 commented Dec 16, 2021

@TalbotGooday Thanks for the reply. Based on this discussions DImuthuUpe#1023, I realized that it is PDFium uses libpng library. And AndroidPdfViewer use PDFium for decoding PDF files.

I cloned your repo and searched for libpng keyword, no result found. So I have two questions:

  1. From your previous comment, I can't find libpng in AndroidPdfViewer, can you please tell me where is it?
  2. If libpng is not in AndroidPdfViewer but it is used in PDFium, how can I update libpng?

@amgad-naiem
Copy link

@hsa1280 The libpng library is prebuild as libmodpng.so and loaded here

The libmodpng.so files are prebuilt for different architechtures here https://github.com/TalbotGooday/PdfiumAndroid/tree/master/src/main/jni/lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants