Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ColorPicker] 样式问题 #2567

Closed
baron04 opened this issue Oct 21, 2023 · 5 comments
Closed

[ColorPicker] 样式问题 #2567

baron04 opened this issue Oct 21, 2023 · 5 comments
Assignees
Labels
🎨 design Something about design or style improvement

Comments

@baron04
Copy link

baron04 commented Oct 21, 2023

重现链接

https://codesandbox.io/s/tdesign-react-demo-forked-gmhj6r?file=/src/main.jsx

重现步骤

在全局样式增加 * { box-sizing: border-box; } 代码,会造成ColorPicker组件的系统预设颜色、最近使用颜色样式出现问题。原因是div.t-color-picker__swatches--items没有指定box-sizing,默认是content-box,如果被全局样式影响,就会造成样式不正常。

期望结果

1、.t-color-picker__swatches--items 元素指定box-sizing;
2、TDesign组件库内部box-sizing有的是border-box,有的是content-box,建议统一;

实际结果

QQ20231021-213110@2x
Environment Info
相关版本 1.3.0
框架版本 / 基础库版本 React 18
系统、浏览器 Mac Chrome
@github-actions
Copy link
Contributor

👋 @baron04,感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善,我们将调查并尽快回复你。

@HaixingOoO
Copy link
Collaborator

感谢 @baron04 您的建议,欢迎PR!!!

@HaixingOoO HaixingOoO added 🎨 design Something about design or style and removed good first issue Good for newcomers labels Oct 25, 2023
@HaixingOoO
Copy link
Collaborator

@uyarn ColorPicker要不要调整成border-box呢?

@uyarn
Copy link
Collaborator

uyarn commented Dec 22, 2023

这个issue @carolin913 来跟进

@uyarn
Copy link
Collaborator

uyarn commented Dec 28, 2023

fixed 1.4.2

@uyarn uyarn closed this as completed Dec 28, 2023
@uyarn uyarn removed the in progress in progress label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 design Something about design or style improvement
Projects
None yet
Development

No branches or pull requests

4 participants