Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Bugs from my comment on SeriousCreepers Thaumic Fixes mod #4

Open
5 of 19 tasks
Vapaman opened this issue Jun 10, 2024 · 8 comments
Open
5 of 19 tasks

Misc Bugs from my comment on SeriousCreepers Thaumic Fixes mod #4

Vapaman opened this issue Jun 10, 2024 · 8 comments
Labels
Thaumcraft Bug Bug in Thaumcraft that should be patched (not a bug in this mod)

Comments

@Vapaman
Copy link

Vapaman commented Jun 10, 2024

Focal manipulator:

  • Editing an already made foci is janky: when you exit the manipulator it removes the pattern.

  • When making remaking a foci, exiting the manipulator messes up the focus and makes it unusable.

  • There seems to be a sound that is supposed to play when failing to create a focus. Currently it only plays it in multiplayer for other nearby players that are not using the manipulator.

  • The Split Trajectory focus effect straight up doesn't work.


Warp:

  • The creeper warp effect is buggy as it plays for other nearby players, not the warped player themself.

  • The overlay when the warpeffect occurs is not implimented/does not play. - I don't know wheter or not this is intentional.

  • In the rare warp event that removes warp ("You have a moment of clarity." ), the warp event text and the warp removed text are overlayed, making it unreadable.


Research table:

  • Some research cards don't seem to show up ex. Balance (mentioned in the Thaumonomicon) and Analyze

  • Shift-clicking things into the table does not work

  • Additional research categories get automatically their own theory and observation points. This clogs up the research, as the reseach points are rarely if ever used.


Other:

  • Potions from pech trading are messed up. Azanor didn't seen to change the potion IDs from their 1.8 state when porting. This should be pretty easy to fix.

Golem bugs:
Golems in general are a bit wonky and inconsistent

Some specific bugs:

  • A golem thats holding an item loses that item if the use seals "Can use empty hand" is enabled

  • The Golem seal GUI doesn't have a darkened background
    2024-08-30_20 09 08

  • Items in the players inventory don't have a tooltip while howering when in the golem seal GUI

  • Requesting items manually sometimes fails

  • Climbing legs makes the golems pathfinding especially wonky and spinny

  • Golem blacklist and whitelist fails for certain types of blocks (not items), especially ones that are coded in the old way using metadata (like botanias living stone and living wood)

  • OreDict seems to not work for wood logs

  • Silverwood logs display incorrectly when held by a golem when extracted from a chest with the provision for oredict:logs

Old issue:

TheCodex6824/ThaumicAugmentation#250

A golem with basic hands has a missing texture at the bottom of its hand

@TheCodex6824
Copy link
Owner

Thanks for making this list. Going through it:

Focal Manipulator:

  1. Confirmed issue
  2. Confirmed issue when remaking a focus (probably same root cause as first issue). Did not occur when making a new focus with latest TC Fix.
  3. Confirmed, but only in ContainerFocalManipulator (the tile itself is fine)
  4. Confirmed weird stuff is going on

Warp:

  1. Confirmed in code
  2. Not sure if this is intentional, but you're not the first person to ask for it back, so it's probably coming back
  3. That is unfortunate - going to have to think about how to fix this one

Research

  1. Are you sure they never appear? Some cards require possibly obscure research aids. Balance looks like it should be given from a bookshelf. Analyze looks like it should appear by default, as long as you have at least 1 non-fundamentals category with observation points.
  2. Yes, this is annoying
  3. This is already fixed by this mod

Other - I'm tempted to throw out how those trades are currently handled and make loot tables, but that would be a bit of a nuclear option. Either way, fixing the potions is pretty straightforward.

Golems - this entire feature is pretty much a bug, and I'm probably going to address it in an update after releasing the mod as there is quite a lot to go through...

@TheCodex6824
Copy link
Owner

Status so far: the focal manipulator issues should all be fixed. Thank you for mentioning split trajectory especially - although I couldn't get them to be completely broken for me, I did find some issues with how they treated mediums and modifiers like scatter, so hopefully they should work more like people are expecting now. Before, it wouldn't treat the 2 separate "branches" as fully separate, so adding things to one branch could lock things out of the other.

@TheCodex6824 TheCodex6824 added the Thaumcraft Bug Bug in Thaumcraft that should be patched (not a bug in this mod) label Jul 7, 2024
@Vapaman
Copy link
Author

Vapaman commented Jul 9, 2024

Are you sure they never appear? Some cards require possibly obscure research aids. Balance looks like it should be given from a bookshelf. Analyze looks like it should appear by default, as long as you have at least 1 non-fundamentals category with observation points.

I have played through the mod multiple times and the cards never appear for me. I only came across them because they were mentioned in the localization files and the thauminomicon research page as an example

The "Balance" card I have mentioned is actually "Universal Theory" ingame it seems because it appears as gilded when selecting a bookshelf
Also Analyze probably doesn't appear since it uses Observations that the player has

@Vapaman
Copy link
Author

Vapaman commented Jul 9, 2024

Here seems to be the cards that don't appear:

Dragon Egg doesnt appear or cannot be selected for some reason
card.dragonegg.name=Draconic Studies
card.dragonegg.text=The aura around the egg swirls with strange and chaotic energies. Occasionally you glimpse strange order in the chaos.

I do not know wheter or not you need a specific research item or block for this to appear but it doesn't seem to appear normally
card.truth.name=Find Truth
card.truth.text=You desperately try and find the truth behind the Eldritch and what it could mean for the world. You gain 10 to 25 Eldritch progress and a bonus draw. You will also gain some temporary Warp.

Probably doesn't work because you need observations for it
card.analyze.name=Analyze %1$s
card.analyze.text=By thoroughly analyzing observations you have made about %1$s you might be able to put together a theory based on the collected data. Lose 1 %1$s observation to gain 25 to 50 %1$s progress and 5 %2$s progress.

Sourced from here: https://github.com/Azanor/thaumcraft-beta/blob/master/en_us.lang

@Vapaman
Copy link
Author

Vapaman commented Jul 9, 2024

Also misc feature that would be cool is making Taint Seeds spread the tainted lands biome, which would enable taintacles to spawn. After killing the seed, the biome should revert to either the biome it was or some default biome, perhaps an eerie biome.

  • Taint Seeds, Research Table, Tainted enemies and much more cause incorrect rendering in many entities golems, constructs, other tainted enemies etc.
  • Inconsistent rendering layers with warded jars
    2024-09-25_22 59 32

@Vapaman
Copy link
Author

Vapaman commented Jul 11, 2024

Flux Condencer issues:

  • Unclogging a flux condenser lattice doesn't get detected by an observer
  • Placing condencer lattices has no sound unless shift placed

Arcane Bore issues:

  • The Arcane bore makes constant Gear Equipping sounds when mining
  • The bore makes the mining rumbling sound only occasionally

@Vapaman
Copy link
Author

Vapaman commented Jul 27, 2024

2024-07-27_07 15 22
2024-07-27_07 16 37

Some of the items I have discovered have this issue:

  • Candles
  • Flux Condenser Lattices
  • Jars
  • Thaumcrafts Banners
  • Arcane Grappler

@Vapaman
Copy link
Author

Vapaman commented Aug 27, 2024

2024-08-27_21 54 46

  • Headband of curiosity, Goggles of Revealing and other baubles worn on the head look weird when glinding with an elytra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Thaumcraft Bug Bug in Thaumcraft that should be patched (not a bug in this mod)
Projects
None yet
Development

No branches or pull requests

2 participants