Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming changes in charlatan #8

Open
RMHogervorst opened this issue Oct 21, 2023 · 1 comment
Open

upcoming changes in charlatan #8

RMHogervorst opened this issue Oct 21, 2023 · 1 comment

Comments

@RMHogervorst
Copy link

Hi Team!

I'm the new maintainer of the charlatan package that you use in some of your functions.
I'm giving you a heads-up because I'm going to change a lot in version 0.6.0 of the package.
There might even be more components you want to incorporate in your package!

Details about your use of charlatan, and what to do about it.

Your package uses

importFrom(charlatan,ch_color_name)
importFrom(charlatan,ch_company)
importFrom(charlatan,ch_credit_card_provider)
importFrom(charlatan,ch_job)
charlatan::ch_element_symbol(1)
@importFrom charlatan ch_name ch_credit_card_provider ch_job
@importFrom charlatan ch_name ch_credit_card_provider ch_job

The functionality of the all these functions remain the same, but it is wise to set the locale to en_US
to make it clear what locale you want to use.
The default locale for all providers in charlatan will always be 'en_US' but future versions will start to warn if locale is not explicitly set.

See ropensci/charlatan#140

Thanks for using the package!

Roel

@statnmap
Copy link
Member

statnmap commented Nov 8, 2023

Thank you for the warning. We'll look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants