Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport compat for SciMLBase@v2 for FMI@v0.10 #196

Closed
SebastianM-C opened this issue Oct 11, 2023 · 5 comments
Closed

Backport compat for SciMLBase@v2 for FMI@v0.10 #196

SebastianM-C opened this issue Oct 11, 2023 · 5 comments

Comments

@SebastianM-C
Copy link

Hi!

FMI@0.10 is still used in some places and recently SciMLBase released v2 (https://github.com/SciML/SciMLBase.jl#v20-breaking-changes). Would it be possible to create a branch based on 0.10.2 on the repo? Then that could be used to backport the SciMLBase version bump by adding a v2 compat and registering 0.10.3 from the commit.

@ChrisRackauckas
Copy link

@ThummeTo could we get this bump in ASAP?

@ThummeTo
Copy link
Owner

ThummeTo commented Oct 12, 2023

Sure.
Just that I get this right: You need a FMI.jl v0.10.3 registered, which is the v0.10.2 but allows for SciMLBase v2 in the project.toml?
If yes, I can do right now.

@ChrisRackauckas
Copy link

Yup that's right

@ThummeTo
Copy link
Owner

Yep, the only related thing that changed were the new ReturnCodes by the ODE solve. I fixed this.
The old tests are running locally now. Registration is triggered.

@ThummeTo
Copy link
Owner

Should be online now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants