Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all members of a NeuralFMU are re-defined when calling the NeuralFMU. That should be made consistent. #131

Open
juguma opened this issue Mar 5, 2024 · 0 comments

Comments

@juguma
Copy link

juguma commented Mar 5, 2024

You can define a ME-NeuralFMU via

function ME_NeuralFMU{M, R}(model::M, p::AbstractArray{<:Real}, re::R) where {M, R}

You can call the created nfmu

function (nfmu::ME_NeuralFMU)(x_start::Union{Array{<:Real}, Nothing} = nfmu.x0,
with a series of arguments. Some of these arguments redefine the values of the member variables of the nfmu, some don't.
This should be made consistent:
Variables which redefine member values are (everything fine here):

  • tSpan
  • x_Start
  • setup
  • reset
  • instantiate
  • freeInstance
  • terminate
  • tolerance
  • parameters <-fmu parameters
  • p <-net parameters

Variables which exist as member values but are not overwritten:

  • recordValues
  • solver <-is only pushed as args to the actual solve
  • saveat
  • sensealg <- that is only a member of the fmu, maybe overwrite only with a warning!?

PS: haven't checked CS-NeuralFMU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant