Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove early stopping from the Gradient descent algorithm #1942

Open
MargaretDuff opened this issue Oct 1, 2024 · 0 comments · May be fixed by #1944
Open

Remove early stopping from the Gradient descent algorithm #1942

MargaretDuff opened this issue Oct 1, 2024 · 0 comments · May be fixed by #1944
Assignees
Labels
bug Something isn't working
Milestone

Comments

@MargaretDuff
Copy link
Member

Description

We should remove this and encourage users to use a callback instead:

rtol: positive float, default 1e-5
optional parameter defining the relative tolerance comparing the current objective function to 0, default 1e-5, see numpy.isclose
atol: positive float, default 1e-8
optional parameter defining the absolute tolerance comparing the current objective function to 0, default 1e-8, see numpy.isclose
"""
def __init__(self, initial=None, objective_function=None, step_size=None, rtol=1e-5, atol=1e-8, preconditioner=None, **kwargs):

Environment

import cil, sys
print(cil.version.version, cil.version.commit_hash, sys.version, sys.platform)
@MargaretDuff MargaretDuff added the bug Something isn't working label Oct 1, 2024
@MargaretDuff MargaretDuff self-assigned this Oct 1, 2024
@MargaretDuff MargaretDuff added this to the v24.3.0 milestone Oct 1, 2024
@MargaretDuff MargaretDuff modified the milestones: v24.3.0, v24.2.0 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Blocked
1 participant