Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DrugChemical conflation defaults to the numerically smallest identifier, which doesn't always work #341

Open
gaurav opened this issue Sep 3, 2024 · 0 comments

Comments

@gaurav
Copy link
Collaborator

gaurav commented Sep 3, 2024

We should replace this with someone smarter -- for example, we could pick the identifier with the shortest label to try to pick the main element and not a salt form.

# Sort this final set of CURIEs from the numerically smallest CURIE suffix to the largest, with
# non-numerical CURIE suffixes sorted to the end.
final_conflation_id_list.extend(list(sorted(prefixes_to_add, key=sort_by_curie_suffix)))

Failure cases:

  • imatinib should be CHEBI:45783 rather than CHEBI:31690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant