Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the lookup allowlist in mvp1 template 7 be arax or rtx-kg2? #41

Open
mbrush opened this issue Jul 29, 2024 · 1 comment
Open

Should the lookup allowlist in mvp1 template 7 be arax or rtx-kg2? #41

mbrush opened this issue Jul 29, 2024 · 1 comment

Comments

@mbrush
Copy link
Contributor

mbrush commented Jul 29, 2024

In the template here, infores:arax is specified in the lookup allowlist:

image

In all other templates, a KP is specified here, not an ARA. Should arax be changed to rtx-kg2 in this template? and generally, what is the convention/rule here?

@karafecho @maximusunc @jdr0887
@karafecho
Copy link
Collaborator

I think you're correct, @mbrush. It's funny because the template is named correctly (i.e., it includes rtxkgs as the target KP). I just created a PR. After this is merged, then I think this issue will be resolved: NCATSTranslator/Feedback#854.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbrush @karafecho